refactor: migrate avoid_using_api#304
Open
solid-illiaaihistov wants to merge 7 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the avoid_using_api lint rule to utilize the analyzer-based RuleContext and RuleVisitorRegistry instead of custom_lint APIs. It replaces AvoidUsingApiLinter with AvoidUsingApiVisitor (extending SimpleAstVisitor), introduces several AST node helper extensions in node_utils.dart, refactors path matching in path_utils.dart, and replaces old integration tests with a comprehensive unit test suite. The review feedback suggests making the rootPath parameter in _getActiveEntries nullable to align with shouldSkipFile and passing context.package?.root.path directly instead of coalescing it to an empty string.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Collaborator
Author
|
I found a bug related to the use of severity in this rule, and I'm working on a fix. |
added 3 commits
July 1, 2026 14:36
… multiple lint codes
…o 249-migrate-avoid_using_api
| }).toList(); | ||
| } | ||
|
|
||
| List<AvoidUsingApiEntryParameters>? _cachedActiveEntries; |
Contributor
There was a problem hiding this comment.
Should be before constructor
Comment on lines
+242
to
+245
| final element = node.element; | ||
| if (element is LocalFunctionElement || | ||
| element is TopLevelFunctionElement || | ||
| element is PropertyAccessorElement) { |
Contributor
There was a problem hiding this comment.
Suggested change
| final element = node.element; | |
| if (element is LocalFunctionElement || | |
| element is TopLevelFunctionElement || | |
| element is PropertyAccessorElement) { | |
| if (node.element | |
| case LocalFunctionElement() || | |
| TopLevelFunctionElement() || | |
| PropertyAccessorElement()) { |
Comment on lines
+256
to
+275
| if (source == null) return; | ||
|
|
||
| final className = entry.className; | ||
| final identifier = entry.identifier; | ||
|
|
||
| switch ((className, identifier)) { | ||
| case (null, null): | ||
| // banSource | ||
| if (matchesSource(node.sourceUrl, source)) { | ||
| reporter.atNode(node, _getLintCode(entry)); | ||
| } | ||
| case (final String className, null): | ||
| // banClassFromSource | ||
| if (node.name.lexeme == className && | ||
| matchesSource(node.sourceUrl, source)) { | ||
| reporter.atNode(node, _getLintCode(entry)); | ||
| } | ||
| default: | ||
| break; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (source == null) return; | |
| final className = entry.className; | |
| final identifier = entry.identifier; | |
| switch ((className, identifier)) { | |
| case (null, null): | |
| // banSource | |
| if (matchesSource(node.sourceUrl, source)) { | |
| reporter.atNode(node, _getLintCode(entry)); | |
| } | |
| case (final String className, null): | |
| // banClassFromSource | |
| if (node.name.lexeme == className && | |
| matchesSource(node.sourceUrl, source)) { | |
| reporter.atNode(node, _getLintCode(entry)); | |
| } | |
| default: | |
| break; | |
| } | |
| if (source == null || | |
| entry.identifier != null || | |
| entry.className == null || | |
| !matchesSource(node.sourceUrl, source)) { | |
| return; | |
| } | |
| reporter.atNode(node, _getLintCode(entry)); |
Comment on lines
+283
to
+302
| final source = entry.source; | ||
| if (source == null) return; | ||
|
|
||
| final className = entry.className; | ||
|
|
||
| switch ((className, entry.identifier)) { | ||
| case (final String className, null): | ||
| // banClassFromSource | ||
| final typeElement = node.declaredType?.element; | ||
| if (typeElement?.name == className && | ||
| matchesSource(typeElement?.libraryUri, source)) { | ||
| reporter.atOffset( | ||
| offset: node.name.offset, | ||
| length: node.name.length, | ||
| diagnosticCode: _getLintCode(entry), | ||
| ); | ||
| } | ||
| default: | ||
| break; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| final source = entry.source; | |
| if (source == null) return; | |
| final className = entry.className; | |
| switch ((className, entry.identifier)) { | |
| case (final String className, null): | |
| // banClassFromSource | |
| final typeElement = node.declaredType?.element; | |
| if (typeElement?.name == className && | |
| matchesSource(typeElement?.libraryUri, source)) { | |
| reporter.atOffset( | |
| offset: node.name.offset, | |
| length: node.name.length, | |
| diagnosticCode: _getLintCode(entry), | |
| ); | |
| } | |
| default: | |
| break; | |
| } | |
| final source = entry.source; | |
| final className = entry.className; | |
| final typeElement = node.declaredType?.element; | |
| if (source == null || | |
| entry.identifier != null || | |
| className == null || | |
| typeElement?.name != className || | |
| !matchesSource(typeElement?.libraryUri, source)) { | |
| return; | |
| } | |
| reporter.atOffset( | |
| offset: node.name.offset, | |
| length: node.name.length, | |
| diagnosticCode: _getLintCode(entry), | |
| ); |
Comment on lines
+330
to
+345
| if (actualClassName != className) { | ||
| return; | ||
| } | ||
|
|
||
| if (node.constructorName.name?.name != expectedConstructorName) { | ||
| return; | ||
| } | ||
|
|
||
| if (!node.argumentList.containsNamed(namedParameter)) { | ||
| return; | ||
| } | ||
|
|
||
| if (matchesSource( | ||
| node.constructorName.type.element?.libraryUri, | ||
| source, | ||
| )) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (actualClassName != className) { | |
| return; | |
| } | |
| if (node.constructorName.name?.name != expectedConstructorName) { | |
| return; | |
| } | |
| if (!node.argumentList.containsNamed(namedParameter)) { | |
| return; | |
| } | |
| if (matchesSource( | |
| node.constructorName.type.element?.libraryUri, | |
| source, | |
| )) { | |
| if (actualClassName == className && | |
| node.constructorName.name?.name == expectedConstructorName && | |
| node.argumentList.containsNamed(namedParameter) && | |
| matchesSource( | |
| node.constructorName.type.element?.libraryUri, | |
| source, | |
| )) { |
Comment on lines
+403
to
+415
| if (element == null) return false; | ||
|
|
||
| final target = element is InterfaceElement | ||
| ? element | ||
| : element.enclosingElement; | ||
| if (target == null) return false; | ||
|
|
||
| if (target is InterfaceElement || target is ExtensionElement) { | ||
| return target.name == className && | ||
| matchesSource(target.libraryUri, source); | ||
| } | ||
|
|
||
| return false; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (element == null) return false; | |
| final target = element is InterfaceElement | |
| ? element | |
| : element.enclosingElement; | |
| if (target == null) return false; | |
| if (target is InterfaceElement || target is ExtensionElement) { | |
| return target.name == className && | |
| matchesSource(target.libraryUri, source); | |
| } | |
| return false; | |
| final target = element is InterfaceElement | |
| ? element | |
| : element?.enclosingElement; | |
| if (target case InterfaceElement() || ExtensionElement() | |
| when target != null) { | |
| return target.name == className && | |
| matchesSource(target.libraryUri, source); | |
| } | |
| return false; |
Contributor
There was a problem hiding this comment.
There are probably more similar refactors possible in this file that I missed
Collaborator
Author
There was a problem hiding this comment.
Thank you! I implemented similar improvements in other parts of this class as well.
added 2 commits
July 1, 2026 17:07
…ingApiVisitor to improve readability and structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249